I don't know about cups, but on my hike we found that the plastic Nalgene water bottles kept odors but the Lexan ones didn't. This was true even if you were mixing ramen in it, then having a pineapple-orange drink mix the next day, then just plain water after that. So I assume that a lexan-type cup would be the same. Twilight GA>ME '98